sebwrede commented on a change in pull request #1051:
URL: https://github.com/apache/systemds/pull/1051#discussion_r486379692
##########
File path:
src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedWorkerHandler.java
##########
@@ -280,8 +281,9 @@ private FederatedResponse execInstruction(FederatedRequest
request) {
ExecutionContext ec = _ecm.get(request.getTID());
BasicProgramBlock pb = new BasicProgramBlock(null);
pb.getInstructions().clear();
- pb.getInstructions().add(InstructionParser
- .parseSingleInstruction((String)request.getParam(0)));
+ Instruction receivedInstruction = InstructionParser
+
.parseSingleInstruction((String)request.getParam(0));
+ pb.getInstructions().add(receivedInstruction);
Review comment:
It does not do anything differently. I thought at some point that I
would need to handle the receivedInstruction, but then I decided against it. I
could change it back like it was before and the code would work the same way,
so right now it is just a question of readability: is the new version easier to
read for you, @Baunsgaard ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
