sebwrede commented on a change in pull request #1237:
URL: https://github.com/apache/systemds/pull/1237#discussion_r625848126
##########
File path: src/main/java/org/apache/sysds/lops/MatMultCP.java
##########
@@ -73,15 +73,15 @@ public String toString() {
@Override
public String getInstructions(String input1, String input2, String
output) {
if(!useTranspose) {
- return
InstructionUtils.concatOperands(getExecType().name(),
+
InstructionUtils.concatBaseOperands(getExecType().name(),
Review comment:
I have done this in other methods and I have not yet experienced any
problems with it. The issue with the hidden variable is that it does not make
any sense to return it from the concatBaseOperands method because of the
internals of InstructionUtils. I think it is working with a thread-local
variable and this means that for subsequent calls from this getInstructions
method, it will always access the same variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
