Baunsgaard commented on a change in pull request #1237:
URL: https://github.com/apache/systemds/pull/1237#discussion_r625893054
##########
File path:
src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedRange.java
##########
@@ -81,6 +88,10 @@ public long getSize() {
size *= getSize(i);
return size;
}
+
+ public int getOverlapNum(){
+ return _overlapNum;
Review comment:
well in compression the overlap state only happens on a right matrix
multiplication, but in federated i can already imagine it happening many times,
if you want to convince me on another name it is fine, but i think having the
same name would be nice.
I guess you chose PART because it is a "PARTial aggregate value". I chose
overlap because it is matrices that could be imagined to be on top of each
other and added together to produce the result. I think that the name should
reflect what it is, and if we have the same concept more places it should be
called the same, that said i don't know what other ppl call it when they have
distributed parts that could be reduced to the actual value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
