Baunsgaard commented on a change in pull request #1237:
URL: https://github.com/apache/systemds/pull/1237#discussion_r625876026
##########
File path:
src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedRange.java
##########
@@ -81,6 +88,10 @@ public long getSize() {
size *= getSize(i);
return size;
}
+
+ public int getOverlapNum(){
+ return _overlapNum;
Review comment:
I don't agree,
Actually now that i think about it, you would not need a boolean nor a
overlapping index, since you are using the "PART" (soon to be "OVERLAP") to
mark if a given federated matrix is overlapping, therefore you should not need
any of this logic to handle any incoming logic, just switch on the federated
type.
again the compare part is easily solved via object compare since it contains
a "random" ID in form of its object pointer that is unique for each object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
