phaniarnab commented on PR #1948: URL: https://github.com/apache/systemds/pull/1948#issuecomment-1826899850
Thanks for the PR. It's a good start @gogokotsev00. Here are a few general comments. - Investigate why some of the tests failed. - Add tests to verify your changes are working. Follow the examples of `RewriteMatrixMultChainOptTest` and `RewriteMatrixMultChainOptTest2`. - Try to integrate the new rewrites in self-contained functions. This way we can easily disable the new rewrites if we encounter bugs or harmful impacts. You can also add static flags to enable/disable the rewrites (e.g. `PUSH_DOWN_TRANSPOSE = true`). - Export developer code style (/dev/CodeStyle_eclipse.xml) to avoid unintended diffs such as space vs tabs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
