mboehm7 commented on PR #1948:
URL: https://github.com/apache/systemds/pull/1948#issuecomment-2002084613
LGTM - thanks for the patch @gogokotsev00 and team. During the merge, I
moved the rewrite to a separate experimental rewrite which is not yet fully
integrated (because I think it's not ready for that). The reason why you did
not see your rewrite being applied as expected is that the transposes for
folded into the generation of constant matrices (with flipped dimensions). By
adding our special program block cut `while(FALSE){}` you can separate them and
the tests fail with an unexpected number of transposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
