phaniarnab commented on PR #1948: URL: https://github.com/apache/systemds/pull/1948#issuecomment-1838396747
Thanks @gogokotsev00 for adding the tests. Besides the correction check, is it possible to add an assertion for the tests to verify if your rewrite is picked up? You can utilize the `Statistics.getCPHeavyHitterCount` module (e.g. matching the number of `transpose`). Rewrites often contradict. This assertion will detect if a future rewrite unintentionally reverts your changes. I also recommend adding few more tests with different matmult patterns, such as using the same input multiple times so that the `mmchain` operator is used (check the `mmchain` tests). Do not worry about the federated test failure. That is not due to your changes. Please rebase on main once Sebastian fixes the issue there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
