phaniarnab commented on PR #2271:
URL: https://github.com/apache/systemds/pull/2271#issuecomment-2993719313

   Thanks, @ReneEnjilian, good start. This is precisely why we need testing.
   Why the rewrites are necessary? Did the old kernels get obsolete in the 
updated cuSparse version?
   
   This means we require more testing to find and fix the broken kernels. As 
you figured out how to enforce gpu to the Junit tests, you can try various 
NN/buitlins to trigger all kernels. Finally, we will need to conduct some 
larger experiments to verify these extensive kernel rewrites are not creating 
performance regressions.
   
   Thanks for your continuous effort.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to