ReneEnjilian commented on PR #2271: URL: https://github.com/apache/systemds/pull/2271#issuecomment-2993813850
I also ran the tests in `LineageTraceGPUTest.java` and `GPULineageCacheEvictionTest.java` and they also passed. I liked these tests because they (and `GPUFullReuseTest.java`) have definitely been tested on the old backend and with them I have a ground truth. If they fail, I know it is due to my changes. However, this can not be said about the other tests. Of course, I ran other existing tests by adding `AutomatedTestBase.TEST_GPU = true;` to enforce execution on the GPU. Examples (among others): - Conv1DTest - Conv2DBackwardDataTest - Conv2DBackwardTest - Conv2DTest - PoolBackwardTest - PoolTest - ReluBackwardTest However, there will be cases when just enforcing on the GPU will result in an error. This does not mean that this error is due to the changes in this pull request. It would also have failed before. For example, `LSTMTest` fails because LSTM is a dedicated operator in CP. If you force it on the GPU, SystemDS does not find gpu_lstm and hence the system crashes. The crash happens during the creation of the instruction string. This is one example of many. The GPU backend lacks behind other parts of the system and hence certain operations will not work. But this was also the case before. To my best knowledge, there are no dedicated GPU tests other than: - GPUFullReuseTest - GPULineageCacheEvictionTest - LineageTraceGPUTest - CellwiseTmplTest - RowAggTmplTest - BuiltinUnaryGPUInstructionTest All those tests pass. Further, I manually changed the sparsity of the matrices in these to ensure that every method I rewrote is covered by those tests (verified via debugger). @mboehm7 Could you please guide us which requirements/expectations need to be fulfilled such that this patch can be merged in ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
