ReneEnjilian commented on PR #2271: URL: https://github.com/apache/systemds/pull/2271#issuecomment-2949402923
Hi @phaniarnab, do you mean with Mark's testing framework the files CellwiseTmplTest.java and RowAggTmplTest.java under test/gpu/codegen? If so, I just ran all the tests specified there and they passed. Further, it is not possible that API changes were missed because then we could not successfully build the project. Jcuda 12 does not cover deprecated API calls from previous CUDA toolkits. My strategy for upgrading the backend was the following: 1. I upgraded Jcuda in the pom.xml and then initiated a fresh build via maven. 2. The build would fail by showing me the error "cannot resolve symbol" for the API calls no longer part of JCuda 12 (and thus CUDA 12). 3. I fixed the deprecated API calls and initiated a fresh build again. Then, maven would show me the next deprecated API calls via the same error. 4. I repeated this process until the build was successfull and all symbols could be resolved. I hope this clarifies why there cannot be any deprecated calls anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
