ywcb00 commented on code in PR #2569:
URL: https://github.com/apache/systemds/pull/2569#discussion_r3690297052
##########
src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedData.java:
##########
@@ -309,20 +311,35 @@ public synchronized static void createWorkGroup() {
private static class DataRequestHandler extends
ChannelInboundHandlerAdapter {
private Promise<FederatedResponse> _prom;
+ // A failure observed before the promise was assigned, e.g., a
rejected SSL handshake
+ private Throwable _failure;
public DataRequestHandler() {
}
- public void setPromise(Promise<FederatedResponse> prom) {
+ public synchronized void setPromise(Promise<FederatedResponse>
prom) {
Review Comment:
Use `synchronized{ }` blocks to mark specific critical sections of the code
instead of declaring the whole method as 'synchronized'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
