gaturchenko commented on code in PR #2569:
URL: https://github.com/apache/systemds/pull/2569#discussion_r3712146648
##########
src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedData.java:
##########
@@ -308,18 +310,43 @@ public synchronized static void createWorkGroup() {
}
private static class DataRequestHandler extends
ChannelInboundHandlerAdapter {
+ // The promise is assigned by the requesting thread, while the
channel events below are handled on the
+ // event loop, and the two orders are not guaranteed: a
rejected SSL handshake already fails the channel
+ // while the requesting thread is still connecting.
+ private final Object _promLock = new Object();
Review Comment:
Done (can't lock on `_prom` but can lock on the class itself via `this`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
