gaturchenko commented on PR #2569: URL: https://github.com/apache/systemds/pull/2569#issuecomment-5144108867
> Thank you very much for this PR @gaturchenko. :) Here a few general comments / questions for my understanding: > > * Please do not include the key password in the XML config file. Instead, use an environment variable for the key password to avoid leaking this secret when publishing the configuration. > * Regarding the configurable hostname verification: In which case do we not want to check whether the hostname matches the certificate? Should we remove this configuration to make the hostname verification mandatory whenever ssl is enabled? > > All the best, David Hey @ywcb00, thanks for the review. Regarding the first point, implemented the change as suggested. About the second, I think the only case is SSH port forwarding, but I think we can remove this option, which I did. Let me know if you have any further comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
