Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403498534
########## File path: src/main/python/systemds/script_building/dag.py ########## @@ -20,11 +20,15 @@ #------------------------------------------------------------- from enum import Enum, auto -from typing import Any, Dict, Union, Sequence +from typing import Any, Dict, Union, Sequence, TYPE_CHECKING from abc import ABC from py4j.java_gateway import JavaObject, JVMView +if TYPE_CHECKING: + # so we don't get cyclic dependencies during runtime + from systemds.context import SystemDSContext + Review comment: OBS here as well. Also minor, extra newline. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
