Baunsgaard commented on a change in pull request #874: Add SystemDSContext for
systemds operations
URL: https://github.com/apache/systemml/pull/874#discussion_r403498970
##########
File path: src/main/python/systemds/utils/converters.py
##########
@@ -44,7 +44,7 @@ def numpy_to_matrix_block(jvm: JVMView, np_arr: np.array):
def matrix_block_to_numpy(jvm: JVMView, mb: JavaObject):
- numRows = mb.getNumRows()
- numCols = mb.getNumColumns()
+ num_ros = mb.getNumRows()
+ num_cols = mb.getNumColumns()
buf =
jvm.org.apache.sysds.runtime.compress.utils.Py4jConverterUtils.convertMBtoPy4JDenseArr(mb)
- return np.frombuffer(buf, count=numRows * numCols,
dtype=np.float64).reshape((numRows, numCols))
+ return np.frombuffer(buf, count=num_ros * num_cols,
dtype=np.float64).reshape((num_ros, num_cols))
Review comment:
:+1: for code style!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
