Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403497973
########## File path: src/main/python/systemds/matrix/matrix.py ########## @@ -22,22 +22,29 @@ __all__ = ['Matrix', 'federated', 'full', 'seq'] import os -from typing import Union, Optional, Iterable, Dict, Tuple, Sequence +from typing import Union, Optional, Iterable, Dict, Tuple, Sequence, TYPE_CHECKING import numpy as np from py4j.java_gateway import JVMView, JavaObject from systemds.utils.converters import numpy_to_matrix_block -from systemds.script_building.dag import VALID_INPUT_TYPES from systemds.matrix.operation_node import OperationNode +from systemds.utils.consts import VALID_INPUT_TYPES + +if TYPE_CHECKING: + # so we don't get cyclic dependencies during runtime Review comment: to avoid cyclic dependencies during runtime from SystemDSContext ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
