kev-inn commented on a change in pull request #966:
URL: https://github.com/apache/systemml/pull/966#discussion_r443132571
##########
File path:
src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedWorkerHandler.java
##########
@@ -115,6 +131,77 @@ private FederatedResponse
constructResponse(FederatedRequest request) {
}
}
+ private FederatedResponse createFrameEncodeMeta(FederatedRequest
request) {
Review comment:
Do you mean you don't like what the function does, or you would prefer
if we but it in a different class?
If the first is the problem, maybe some details (or I refer to the comment
further above), otherwise I believe we should anyway start thinking about
splitting `FederatedWorkerHandler` up into some/one class that handles some
types of tasks. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
