Baunsgaard commented on a change in pull request #966:
URL: https://github.com/apache/systemml/pull/966#discussion_r443136339
##########
File path:
src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedWorkerHandler.java
##########
@@ -115,6 +131,77 @@ private FederatedResponse
constructResponse(FederatedRequest request) {
}
}
+ private FederatedResponse createFrameEncodeMeta(FederatedRequest
request) {
Review comment:
It is purely a comment on location.
I think adding a FedEncoder file inside
`sysds/runtim/transform/encode/fedencode.java`, could be a good because it
keeps the functionality collected at the same place the other transform
operations are located.
`anyway start thinking about splitting FederatedWorkerHandler`
- I'm always a fan of splitting things apart :smile: (maybe to much)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
