kev-inn commented on a change in pull request #966:
URL: https://github.com/apache/systemml/pull/966#discussion_r443464831



##########
File path: 
src/test/java/org/apache/sysds/test/functions/federated/FederatedConstructionTest.java
##########
@@ -142,7 +142,7 @@ public void federatedConstruction(Types.ExecMode execMode, 
String testFile, Stri
                        DMLScript.USE_LOCAL_SPARK_CONFIG = true;
                }
                fullDMLScriptName = HOME + testFile + ".dml";
-               programArgs = new String[] {"-args", "\"localhost:" + port + 
"/" + input(inputIdentifier) + "\"",
+               programArgs = new String[] {"-args", 
TestUtils.federatedAddress("localhost", port, input(inputIdentifier)),

Review comment:
       How does one mark something as warmup? Do you mean with a label, because 
I would need to create a new one I guess? I added it as an improvement with low 
priority.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to