On 12/06/15 16:50, Stian Soiland-Reyes wrote:
Well, this is my take on "release early, release often" (although it
is not early. Taverna Language is ready to be released, as we have
already discussed several times on this list. It's a foundation for
the rest of Taverna 3. There would probably be more releases of
Taverna Language later in summer/autumn, particularly to include the
Command Line tool from GSOC.
Not sure what the point you're making is here. My comments are intended
to move the process forward and as first-time checking is time
consuming, I makde some comments as early as I could.
This isn't a challenge-response setup - you are allowed to help the
reviewers check the files!
It's important NOTICE be minimal. LICENSE can contain more material.
Nowadays, "include the license" (in LICENSE) can be done with links.
Going through, and as far as I can tell, none of the notices listed
require their license text to be implicitly bundled or mentioned in
such LICENSE. The individual 'foreign' files have corresponding
copyright headers - see rat excludes in pom.xml
And you are not shipping anything else?
The W3C license have:
http://www.w3.org/Consortium/Legal/2015/doc-license
It seems by linking to be retrospective
http://www.w3.org/Consortium/Legal/copyright-documents goes there now.
The materials contained in the Site may be downloaded or copied
provided that ALL copies retain the copyright and any other
proprietary notices contained on the materials. No material may be
modified, edited or taken out of context such that its use creates
a false or misleading statement or impression as to the positions,
statements or actions of W3C.
From that text alone, I don't think that needs an entry in NOTICE - it
says that the original materials need to retain any copyright and any
other proprietary notices so where the original file is unchanged, there
is no need to be in NOTICE.
It's from the document license that there is:
"""
We request that authorship attribution be provided in any software
"""
and that suggests an entry in NOTICE.
The only modifications to W3C files have been to *add* their copyright
headers where it was just implicit from their parent specification,
always tricky when the input materials - I have seen LICENSE_README
and/or NOTICE files in the directories where a lot of W3C files are.
e.g. compare http://www.w3.org/2001/xml.xsd (in the http tar-pit) and
https://github.com/apache/incubator-taverna-language/blob/master/taverna-scufl2-schemas/src/main/resources/org/apache/taverna/scufl2/rdfxml/xsd/xml.xsd
The CC licensed stuff basically says:
Attribution — You must give appropriate credit, provide a link to the license,
and indicate if changes were made. You may do so in any reasonable manner, but
not in any way that suggests the licensor endorses you or your use.
which an entry in NOTICE should suffice, but additionally here as well
I added copyright headers if it was missing.
https://creativecommons.org/licenses/by/3.0/legalcode says:
You must keep intact all notices that refer to this License and to the
disclaimer of warranties with every copy of the Work You Distribute or Publicly
Perform. When You Distribute or Publicly Perform the Work, You may not impose
any effective technological measures on the Work that restrict the ability of a
recipient of the Work from You to exercise the rights granted to that recipient
under the terms of the License. This Section 4(a) applies to the Work as
incorporated in a Collection, but this does not require the Collection apart
from the Work itself to be made subject to the terms of this License.
Here the Collection is the taverna-language source zip.
The DISCLAIMER is auto-generated by
<resourceBundle>org.apache:apache-incubator-disclaimer-resource-bundle:1.1</resourceBundle>
the template picks up the <name> from pom.xml
https://github.com/apache/incubator-taverna-maven-parent/blob/master/pom.xml#L278
Never trust the machines!
Presumably the problem here is that we have multiple top-level
projects. So should all the projects have the same DISCLAIMER with
just "Apache Taverna is an effort .." instead?
Yes.
Like some of the N&L generators, they do simpel cases but for anythign
else, it'll need proper files. Probably if you put a DISCLAIMER into
git, it'll use that.
As this is a do-once while in the incubator, it's not a burden.
DEPENDENCIES is also auto-generated by apache-jar-resource-bundle.
Ditto - though I have not come across an autogenerator that did track
through the POM in any decent way.
There is one per submodule.. the top level project does not have any
directly <dependencies> and hence it is empty.
See for instance
taverna-language-0.15.0-incubating/taverna-robundle/target/classes/META-INF/DEPENDENCIES
after building.
>> Release candidates are signed with a GPG key available at:
>>
>> https://dist.apache.org/repos/dist/release/incubator/taverna/KEYS
I really wish I had time to make a technical contribution to Taverna but
that's unlikely. Please remove my key.
Andy
On 12 June 2015 at 11:08, Andy Seaborne <[email protected]> wrote:
Some first reactions to start discussions:
How does this fit with the release email from Shoaib? I can guess, maybe
wrongly - I think others might find it hard to piece the picture together.
The NOTICE for language seems very large yet the LICENSE is just the AL.
It would speed up reviewing by mentors (and IPMC later) if there were some
notes as to what each inclusion is and where it is included. Is it modified?
Are any from upstream NOTICE files (i.e. necessary by other products
usage?).
Isn't the bulk of the code (C) University of Manchester? That should be at
the top.
NOTICE and LICENCE should be ASCII (theer are UTF-8 copyright symbols).
DEPENDENCIES is somewhat minimal. The <dependencies> not so.
The disclaimer is wrong:
[[
Apache Taverna Language APIs (Scufl2, Databundle) is an effort undergoing
incubation at the Apache Software
Foundation (ASF), sponsored by the Apache Incubator PMC.
]]
Taverna is undergoing incubation, not the sofware item.
Andy
On 11/06/15 15:48, Stian Soiland-Reyes wrote:
I am pleased to be calling this vote for the source release of
Apache Taverna Maven Parent 1-incubating
Apache Taverna Language 0.15.0-incubating
Apache Taverna Language is a set of APIs for workflow definitions (SCUFL2)
and workflow inputs/outputs/run (DataBundle), as consumed and produced by
the
Apache Taverna workflow system. The API includes support for working with
Research Object Bundles, and loading/saving Taverna workflows in different
formats.
The release candidates to be voted over are available at:
https://dist.apache.org/repos/dist/dev/incubator/taverna/source/taverna-parent-1-incubating-RC2/
https://dist.apache.org/repos/dist/dev/incubator/taverna/source/taverna-language-0.15.0-incubating-RC2/
SHA-1 checksums:
8199880048a59cde622e0caa24c3bc3d83bc5d5a
taverna-parent-1-incubating-source-release.zip
7032e9d2be834f7c029aae562b62613481bf6939
taverna-language-0.15.0-incubating-source-release.zip
MD5 checksums:
7f9b107b9f1dc0407783ac0ad484d6ea
taverna-parent-1-incubating-source-release.zip
35d3085b596b2dd4b30a0234259efade
taverna-language-0.15.0-incubating-source-release.zip
Build the release candidate in the above order, using:
mvn clean install
The release candidates correspond to the following git commits:
https://git-wip-us.apache.org/repos/asf?p=incubator-taverna-maven-parent.git;a=commit;h=3ba669c78782d3fc3b548e2a512d201ee922b34a
https://git-wip-us.apache.org/repos/asf?p=incubator-taverna-language.git;a=commit;h=3340e2090e604b40ac0b88675f57c1d12032d060
Release candidates are signed with a GPG key available at:
https://dist.apache.org/repos/dist/release/incubator/taverna/KEYS
A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachetaverna-1003/
The changelog for this release is available from JIRA:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318322&version=12332247
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318322&version=12332246
Please vote on releasing these packages as:
Apache Taverna Maven Parent 1-incubating
Apache Taverna Language 0.1.0-incubating
The vote is open for at least 72 hours and passes if a
majority of at least three +1 Apache Taverna PPMC votes are cast.
[ ] +1 Release this package
[ ] 0 I don't feel strongly about it, but don't object
[ ] -1 Do not release this package because...
Anyone can participate in testing and voting, not just
committers, please feel free to try out the release candidate
and provide your votes.
(Before anyone asks, RC1 was a release candidate tag I dropped as it
used an older Apache super-pom)
