I struggled to remove DEPENDENCIES as it is injected in by the Apache Commons parent assembly that builds source-release.zip
There seems to be some Maven bug in that the DEPENDENCIES of the first non-pom module (scufl2-api) is used in the root project - thus the source-release gets a non-sensical DEPENDENCIES. Trying to modify the assembly, e.g. to exclude taverna-wfdesc turned tricky - basically reconstructing the whole assembly from scratch. I don't think we want to be maintaining that in our builds across all our projects, so I have rather added a generic DEPENDENCIES to override it: stain@biggie-utopic:~/src/taverna/incubator-taverna-language$ cat DEPENDENCIES Dependencies are declared within each Maven submodule. See */target/classes/META-INF/DEPENDENCIES after running: mvn process-resources On 13 June 2015 at 18:03, Andy Seaborne <[email protected]> wrote: >> Please vote on releasing these packages as: >> >> Apache Taverna Maven Parent 1-incubating > > > +0 with comments. > I'd like to see (1) fixed. > > Checks done: > .asc : good > .md5 : good > .sha1 : good > maven build and verify ; good. > > Needs correcting: > > 1/ The text in DISCLAIMER and NOTICE says: > "Apache Taverna (incubating) Maven parent" > > Other points: (should be noted and fixed sometime): > > 2/ There should be a NOTICE file in git. > LICENSE and NOTICE go around in pairs. > > 3/ LICENSE removed the text "END OF TERMS AND CONDITIONS" > That is part of the license, to match text at the start so should be > included IMO. > > 4/ DEPENDENCES > If there is going to be a DEPENDENCES, it would be good to include junit > which is EPL. > > Noted in passing: > > 5/ Can't checkout from URL in the email: > Better to use > https://git-wip-us.apache.org/repos/asf/incubator-taverna-maven-parent > > 6/ README.md is a github README. > e.g.Build status > so not focused on source-release. Slightly confusing. > > 7/ pom.xml seems to have suffered reformatting. > > 8/ It build java tests! > > Possibly because there is a maven-compiler-plugin etc in the build, not just > in the <pluginManagement> section, I get: > > """ > [WARNING] JAR will be empty - no content was marked for inclusion! > """ > and there is a -tests jar even thouhg it's packaged as pom. > > Andy > > >> Apache Taverna Language 0.1.0-incubating >> >> >> The vote is open for at least 72 hours and passes if a >> majority of at least three +1 Apache Taverna PPMC votes are cast. >> >> [ ] +1 Release this package >> [ ] 0 I don't feel strongly about it, but don't object >> [ ] -1 Do not release this package because... > > -- Stian Soiland-Reyes Apache Taverna (incubating), Apache Commons RDF (incubating) http://orcid.org/0000-0001-9842-9718
