Hi,

Thanks for pointing that out. I have fixed them
https://github.com/apache/incubator-taverna-common-activities/pull/13

Thanks !

On Thu, Aug 4, 2016 at 12:18 AM, Gale Naylor <[email protected]>
wrote:

> I have a couple of questions about the CWL code.
>
> (1) In CwlServiceDesc.java, line 50:
> Should CwlDumyActivity.class be called CwlDummyActivity.class?
> (Because it looks like the code creates a "dummy" class.)
>
> (2) In CwlServiceProvider.java, lines 47 and 48:
> Should the constant names be upper case? e.g., PROVIDER_NAME and
> PROVIDER_ID?
>
> Thanks!
> Gale
>

Reply via email to