In CwlContextualView.java, should cwutil be cwlUtil? Also, I notice in this CWL User Guide ( http://www.commonwl.org/draft-3/UserGuide.html ) it says the basecommand field comes before the input and output parameters.
Gale On Fri, Aug 5, 2016 at 10:42 AM Gale Naylor <[email protected]> wrote: > In CwlContextualView.java (I used the wrong filename in my previous email) > I'm also curious about the two private, final (but not static) constants > (?): configurationBean and activity. > > I'm not sure this StackOverflow answer is 100% relevant because > configurationBean and activity do not have initial values, but this is all > I've been able to find online: > http://stackoverflow.com/questions/1415955/private-final-static-attribute-vs-private-final-attribute > . > > Can anyone point me to information that would help me understand this > nomenclature? > > Thanks, > > Gale > > On Fri, Aug 5, 2016 at 10:24 AM Gale Naylor <[email protected]> > wrote: > >> I have a couple of additional questions/observations about the CWL code. >> >> In CwlContextView.java: >> >> - Starting in line 101, is a String called "summery" - I think this may >> mean "summary". (It looks like the CWL configuration information is being >> summarized here.) >> >> - I'm wondering if in lines 121 and 122 it's permissible to use the >> DESCRIPTION constant instead of the hard-coded value "description"? >> >> Thanks, >> >> Gale >> >> On Thu, Aug 4, 2016 at 5:56 AM Gale Naylor <[email protected]> >> wrote: >> >>> Great! >>> >>> Gale >>> >>> On Wed, Aug 3, 2016, 9:22 PM Thilina Manamgoda <[email protected]> >>> wrote: >>> >>>> Hi, >>>> >>>> Thanks for pointing that out. I have fixed them >>>> https://github.com/apache/incubator-taverna-common-activities/pull/13 >>>> >>>> Thanks ! >>>> >>>> On Thu, Aug 4, 2016 at 12:18 AM, Gale Naylor < >>>> [email protected]> >>>> wrote: >>>> >>>> > I have a couple of questions about the CWL code. >>>> > >>>> > (1) In CwlServiceDesc.java, line 50: >>>> > Should CwlDumyActivity.class be called CwlDummyActivity.class? >>>> > (Because it looks like the code creates a "dummy" class.) >>>> > >>>> > (2) In CwlServiceProvider.java, lines 47 and 48: >>>> > Should the constant names be upper case? e.g., PROVIDER_NAME and >>>> > PROVIDER_ID? >>>> > >>>> > Thanks! >>>> > Gale >>>> > >>>> >>>
