Github user therajanmaurya commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-mobile/pull/56#discussion_r169134000
--- Diff:
app/src/main/java/org/apache/taverna/mobile/ui/favouriteworkflowdetail/FavouriteWorkflowDetailPresenter.java
---
@@ -135,22 +130,26 @@ public void onError(Throwable e) {
}
@Override
- public void onNext(License license) {
- getMvpView().showLicense(license);
+ public void onComplete() {
+ getMvpView().showLicenseProgress(false);
}
}));
}
public void setFavourite(String id) {
-
-
- mCompositeSubscription.add(mDataManager.setFavoriteWorkflow(id)
+ checkViewAttached();
+ compositeDisposable.add(mDataManager.setFavoriteWorkflow(id)
.observeOn(AndroidSchedulers.mainThread())
.subscribeOn(Schedulers.io())
- .subscribe(new Observer<Boolean>() {
+ .subscribeWith(new DisposableObserver<Boolean>() {
@Override
- public void onCompleted() {
-
+ public void onNext(Boolean b) {
--- End diff --
This Boolean `b` name should be `favoriteStatus`
---
