[GitHub] incubator-taverna-mobile pull request #56: Migration RxJava 1 -> RxJava2

[therajanmaurya]

Github user therajanmaurya commented on a diff in the pull request:

    
https://github.com/apache/incubator-taverna-mobile/pull/56#discussion_r169137166
  
    --- Diff: 
app/src/main/java/org/apache/taverna/mobile/ui/workflow/WorkflowPresenter.java 
---
    @@ -111,33 +111,36 @@ public void onError(Throwable e) {
                         }
     
                         @Override
    -                    public void onNext(String s) {
    -                        getMvpView().performSearch(s);
    -                        if (!TextUtils.isEmpty(s)) {
    -                            searchWorkflow(1, s);
    -                        }
    +                    public void onComplete() {
    +
                         }
    -                });
    -        mSubscriptions.add(mSearchViewSubscription);
    +                }));
    +        compositeDisposable.add(compositeDisposable);
    --- End diff --
    
    As we are using `CompositeDisposable`, Please remove this line. this line 
is making no sense.


---