Github user therajanmaurya commented on a diff in the pull request:

    
https://github.com/apache/incubator-taverna-mobile/pull/56#discussion_r169136376
  
    --- Diff: 
app/src/main/java/org/apache/taverna/mobile/ui/login/LoginPresenter.java ---
    @@ -76,16 +75,15 @@ public void onError(Throwable e) {
                         }
     
                         @Override
    -                    public void onNext(User user) {
    -
    +                    public void onComplete() {
    +                        getMvpView().showDashboardActivity();
    +                        getMvpView().showProgressDialog(false);
    --- End diff --
    
    `onComplete()` get called in the last of the cycle so basically, we use 
this when we make list of request and want to check all of them went well or 
not. Please move 
    `
    getMvpView().showDashboardActivity();
    getMvpView().showProgressDialog(false);
    `
    in onNext.


---

Reply via email to