Github user sagar15795 commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-mobile/pull/56#discussion_r169214069
--- Diff:
app/src/main/java/org/apache/taverna/mobile/ui/workflow/WorkflowPresenter.java
---
@@ -84,25 +82,27 @@ public void onError(Throwable e) {
}
@Override
- public void onNext(Workflows workflows) {
- getMvpView().showProgressbar(false);
- getMvpView().removeLoadMoreProgressbar();
- getMvpView().showWorkflows(workflows);
+ public void onComplete() {
+
}
}));
}
public void attachSearchHandler(final SearchView searchView) {
- mSearchViewSubscription = RxSearch.fromSearchView(searchView)
+ checkViewAttached();
+ compositeDisposable.add(RxSearch.fromSearchView(searchView)
.distinctUntilChanged()
.debounce(300, TimeUnit.MILLISECONDS)
.observeOn(AndroidSchedulers.mainThread())
.subscribeOn(Schedulers.io())
- .subscribe(new Subscriber<String>() {
+ .subscribeWith(new DisposableObserver<String>() {
@Override
- public void onCompleted() {
-
+ public void onNext(String s) {
--- End diff --
This String `s` name should be `searchText`
---