Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/35#discussion_r100709175
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriter.java
---
@@ -81,14 +84,23 @@ private void startFlushThread() {
flushThread = new Thread("tephra-prune-upper-bound-writer") {
@Override
public void run() {
- while ((!isInterrupted()) && isRunning()) {
+ Service.State serviceState = state();
+ while ((!isInterrupted()) &&
+ (serviceState.equals(Service.State.NEW) ||
serviceState.equals(Service.State.STARTING) ||
--- End diff --
hmm - do you think it would simplify the code if we go back to using a
`stop` flag?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
