Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/35#discussion_r100940705
  
    --- Diff: 
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
 ---
    @@ -454,28 +442,38 @@ protected Filter getTransactionFilter(Transaction tx, 
ScanType type, Filter filt
         return TransactionFilters.getVisibilityFilter(tx, ttlByFamily, 
allowEmptyValues, type, filter);
       }
     
    -  private void 
initPruneState(ObserverContext<RegionCoprocessorEnvironment> c) {
    -    Configuration conf = getConfiguration(c.getEnvironment());
    -    // Configuration won't be null in TransactionProcessor but the derived 
classes might return
    -    // null if it is not available temporarily
    +  protected void initializePruneState(RegionCoprocessorEnvironment env) {
    --- End diff --
    
    Good to add javadoc for the protected method


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to