Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/35#discussion_r100932301
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -356,8 +356,8 @@ public InternalScanner
preCompactScannerOpen(ObserverContext<RegionCoprocessorEn
@Override
public void postCompact(ObserverContext<RegionCoprocessorEnvironment> e,
Store store, StoreFile resultFile,
CompactionRequest request) throws IOException {
- // Persist the compaction state after a succesful compaction
- if (compactionState != null) {
+ // Persist the compaction state after a successful compaction
+ if (Boolean.TRUE.equals(pruneEnable)) {
--- End diff --
It would be better to change this check to `compactionState != null`.
Otherwise there is a race condition during `initializePruneState()`, where
`pruneEnable` could be `true`, but `compactionState` is still not initialized.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
