On both machines we should use int64_t or w\e is appropriate.
On 19 Nov 2010 16:49, "Piotr Bartosiewicz (JIRA)" <[email protected]> wrote:
>
> [
https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933996#action_12933996]
>
> Piotr Bartosiewicz commented on THRIFT-916:
> -------------------------------------------
>
> Verified, no warnings when make and make check with this flags.
>
> The long-long warnings are caused by wrong 64bit constant definitions. On
a 32 bit machine 64bit constant should ends with LL, but on a 64 bit machine
it should ends only with one L.
>
>> gcc warnings in c++ header files
>> --------------------------------
>>
>> Key: THRIFT-916
>> URL: https://issues.apache.org/jira/browse/THRIFT-916
>> Project: Thrift
>> Issue Type: Improvement
>> Components: C++ - Library
>> Affects Versions: 0.4
>> Reporter: Piotr Bartosiewicz
>> Assignee: Roger Meier
>> Attachments: DebianLenny_error.log, make-k.log,
THRIFT-916_Wall_pedantic__noerrors.patch,
THRIFT-916_Wall_Wextra__NOWARNINGS_DebianLenny.patch,
THRIFT-916_Wall_Wextra_pedantic_Wno-long-long_Wno-variadic-macros_Wno-overflow_NOWARNINGS_DebianLenny.patch,
v1-enable-wall-werror.patch, v1-fix-format-strings.patch,
v1-fix-java-style-and-warnings.patch, v1-fix-more-warnings.patch,
v1-fix-random-silly-warnings.patch, v2-fix-all-warnings.patch,
v3-fix-all-warnings.patch, v4-fix-all-warnings.patch
>>
>>
>> I tried to add an extra gcc warning options in my project but a number of
warnings was emmited from thrift headers.
>> Following the boost library recommendations, code should be clean with
"-Wall -Wextra -pedantic" options.
>> Currently only with -Wall thrift has no warnings.
>> Other options worth considering (but require more work) are -Wconversion
-Wold-style-cast
>> So the task is to improve the thrift headers.
>> I suggest also update all the thrift makefiles so the thrift sources an
tests will indicate the faulty code.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
