[
https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934328#action_12934328
]
Christian Lavoie commented on THRIFT-916:
-----------------------------------------
No it doesn't, but you need to run make distclean and ./bootstrap.sh
again (easiest way to test is with a shiny new svn client; you
shouldn't have to, but I'm about 80% sure I say automake get it wrong
at least once in the last few weeks) -- the pragmas your patch
introduced using do _not_ work with gcc-4.2 (despite what the gcc docs
say, I've tested it a few times to be sure).
Also, make sure NOT to define CFLAGS, CXXFLAGS and CPPFLAGS.
That means that configure is not passing the flags my patch defines to
the compiler somehow (-Wno-unused removes that warning). Either it's
not regenerating the Makefile's, or you're overriding the C*FLAGS that
make defines by default.
Same as above, -Wno-unused should remove that (-Wno-unused is a
superset of -Wno-unused-function and -Wno-unused-label).
Sadly, no can do on this box.
Have fun, Christian
http://linkedin.christianlavoie.net
"I won't let you fall apart."
> gcc warnings in c++ header files
> --------------------------------
>
> Key: THRIFT-916
> URL: https://issues.apache.org/jira/browse/THRIFT-916
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.4
> Reporter: Piotr Bartosiewicz
> Assignee: Roger Meier
> Attachments: DebianLenny_error.log, make-k.log,
> THRIFT-916_Wall_pedantic__noerrors.patch,
> THRIFT-916_Wall_Wextra__NOWARNINGS_DebianLenny.patch,
> THRIFT-916_Wall_Wextra_pedantic_Wno-long-long_Wno-variadic-macros_Wno-overflow_NOWARNINGS_DebianLenny.patch,
> v1-enable-wall-werror.patch, v1-fix-format-strings.patch,
> v1-fix-java-style-and-warnings.patch, v1-fix-more-warnings.patch,
> v1-fix-random-silly-warnings.patch, v1-long-long-to-int64_t.patch,
> v2-enable-wall-werror.patch, v2-fix-all-warnings.patch,
> v3-enable-wall-werror.patch, v3-fix-all-warnings.patch,
> v4-fix-all-warnings.patch
>
>
> I tried to add an extra gcc warning options in my project but a number of
> warnings was emmited from thrift headers.
> Following the boost library recommendations, code should be clean with "-Wall
> -Wextra -pedantic" options.
> Currently only with -Wall thrift has no warnings.
> Other options worth considering (but require more work) are -Wconversion
> -Wold-style-cast
> So the task is to improve the thrift headers.
> I suggest also update all the thrift makefiles so the thrift sources an tests
> will indicate the faulty code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
