v3 removes Werror everywhere, turns on Wall and fixes the flex warnings the right way.
On Sat, Nov 20, 2010 at 2:10 AM, Roger Meier (JIRA) <[email protected]> wrote: > > [ > https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934109#action_12934109 > ] > > Roger Meier commented on THRIFT-916: > ------------------------------------ > > just committed my latest patch! > > I still disagree with [^v2-enable-wall-werror.patch], as mentioned on mailing > list > => we should not break builds for a warning, not that nice for people using > brand new compilers or operating systems by setting {{-Werror}} > > Christians patch [^v2-enable-wall-werror.patch] to use int64_t instead of > long long makes absolutely sense! > > but there are still a few long long warnings...we should fix them as next! > >> gcc warnings in c++ header files >> -------------------------------- >> >> Key: THRIFT-916 >> URL: https://issues.apache.org/jira/browse/THRIFT-916 >> Project: Thrift >> Issue Type: Improvement >> Components: C++ - Library >> Affects Versions: 0.4 >> Reporter: Piotr Bartosiewicz >> Assignee: Roger Meier >> Attachments: DebianLenny_error.log, make-k.log, >> THRIFT-916_Wall_pedantic__noerrors.patch, >> THRIFT-916_Wall_Wextra__NOWARNINGS_DebianLenny.patch, >> THRIFT-916_Wall_Wextra_pedantic_Wno-long-long_Wno-variadic-macros_Wno-overflow_NOWARNINGS_DebianLenny.patch, >> v1-enable-wall-werror.patch, v1-fix-format-strings.patch, >> v1-fix-java-style-and-warnings.patch, v1-fix-more-warnings.patch, >> v1-fix-random-silly-warnings.patch, v1-long-long-to-int64_t.patch, >> v2-enable-wall-werror.patch, v2-fix-all-warnings.patch, >> v3-enable-wall-werror.patch, v3-fix-all-warnings.patch, >> v4-fix-all-warnings.patch >> >> >> I tried to add an extra gcc warning options in my project but a number of >> warnings was emmited from thrift headers. >> Following the boost library recommendations, code should be clean with >> "-Wall -Wextra -pedantic" options. >> Currently only with -Wall thrift has no warnings. >> Other options worth considering (but require more work) are -Wconversion >> -Wold-style-cast >> So the task is to improve the thrift headers. >> I suggest also update all the thrift makefiles so the thrift sources an >> tests will indicate the faulty code. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > -- Have fun, Christian http://linkedin.christianlavoie.net "I won't let you fall apart."
