[
https://issues.apache.org/jira/browse/THRIFT-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014688#comment-13014688
]
Michael Stockton commented on THRIFT-1108:
------------------------------------------
Alex,
I'm not sure if it makes sense to use @handle.connect. You can't open an
SSLSocket in a non-blocking fashion which makes the select loop and other logic
pointless.
https://github.com/tarcieri/openssl-nonblock
It appears non-blocking methods were added to SSL in ruby-1.9.2. It would be
nice to have this work with pre 1.9.2 so you have to add a dependency on the
openssl-nonblock gem. With the nonblock gem or ruby-1.9.2, I think you'll be
able to slim this patch down further if you merely make the same calls to an
ssl socket or regular socket.
Can you also add some test code? See lib/rb/spec/.
Michael
> SSL support for the Ruby library
> ---------------------------------
>
> Key: THRIFT-1108
> URL: https://issues.apache.org/jira/browse/THRIFT-1108
> Project: Thrift
> Issue Type: Improvement
> Components: Ruby - Library
> Affects Versions: 0.6
> Reporter: Alex
> Priority: Minor
> Labels: ssl
> Attachments: ssl_support.diff
>
>
> Attached are modified versions of the socket and server_socket files which
> include SSL support. I do not consider these implementations complete,
> however they work well for my purposes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
