[
https://issues.apache.org/jira/browse/THRIFT-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016075#comment-13016075
]
Michael Stockton commented on THRIFT-1108:
------------------------------------------
Alex, I'm still not sure if your call to @handle.connect_nonblock will work on
ruby-1.8.7 without using the openssl-nonblock gem. Can you clarify how this
will work?
I was thinking more along the lines of having a method which a subclass can
override which return what @handle should be -- whether than be an ssl socket
or regular socket. This way, you avoid a superclass and subclass both defining
@handle.
Have you though about supporting cert and key options? If not, it may be better
to replace "ca=nil" in the constructor with "ssl_options = {}". Worst case,
someone can add support later without affecting the constructor's arguments.
Your patch is looking better but we really need test code to go along with it.
What problem are you having with rspec?
> SSL support for the Ruby library
> ---------------------------------
>
> Key: THRIFT-1108
> URL: https://issues.apache.org/jira/browse/THRIFT-1108
> Project: Thrift
> Issue Type: Improvement
> Components: Ruby - Library
> Affects Versions: 0.6
> Reporter: Alex
> Priority: Minor
> Labels: ssl
> Attachments: ssl_support.diff
>
>
> Attached are modified versions of the socket and server_socket files which
> include SSL support. I do not consider these implementations complete,
> however they work well for my purposes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
