[ 
https://issues.apache.org/jira/browse/THRIFT-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020817#comment-13020817
 ] 

Alex edited comment on THRIFT-1108 at 4/18/11 5:57 PM:
-------------------------------------------------------

It seems that the Rakefile was written for a very old version of rspec, and as 
such it is not working on my system.

Regarding Ruby 1.8.7, I only use 1.9.2. This code may not be appropriate for 
inclusion in to the main, however I wanted it to be available to those who do 
use a more recent version of Ruby. I've made some changes to the patch as of 
late though, because the patch does not work as-is with a nonblocking server 
(and a framed transport). The problem is that calling select() on an OpenSSL 
BIO only works once (from what I can tell), and as a result you need to call 
sysread instead of readpartial and wrap it in a Timeout in the read method of 
Socket. I have tested my changes with both a SimpleServer and a 
NonblockingServer, and it seems to work fine. Do you want me to update this 
ticket with my changes, or do you want to discuss this via another medium?

      was (Author: centromere):
    It seems that the Rakefile was written for a very old version of rspec, and 
as such it is not working on my system.
  
> SSL support for the Ruby library 
> ---------------------------------
>
>                 Key: THRIFT-1108
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1108
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Ruby - Library
>    Affects Versions: 0.6
>            Reporter: Alex
>            Priority: Minor
>              Labels: ssl
>         Attachments: ssl_support.diff
>
>
> Attached are modified versions of the socket and server_socket files which 
> include SSL support. I do not consider these implementations complete, 
> however they work well for my purposes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to