[
https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190346#comment-13190346
]
Roger Meier commented on THRIFT-1353:
-------------------------------------
Your repo does not reflect the complete Thrift codebase, e.g. compiler is
missing. I recommend you to fork from the Apache Thrift github mirror located
at https://github.com/apache/thrift. This will simplify code sync and enable
better alignment of the two JavaScript implementations and nodejs
imrovements... we did also a lot of changes on the compiler! the other thing is
the testsuite, see THRIFT-1134
It is really difficult to manage a project with so many languages and that's
why unit test and cross language tests are so important, see THRIFT-847 =>
test/test.sh integrates also some node cross language tests
I really like to merge your stuff in, but I need a patch and whenever possible
unit tests.
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Labels: node, nodejs
> Fix For: 0.9
>
>
> I vote that the thrift library switches to the performance branch at
> https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the
> performance branch seems focused on this very issue. Also it includes the
> excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
