[
https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274755#comment-13274755
]
Henrique Mendonca commented on THRIFT-1353:
-------------------------------------------
Thanks for you feedback Wade. I think we should check this in as it fix some
bugs and improve other stuff. Got your code to run but didn't manage to create
a proper patch (too many files and other conflicts). I also don't work directly
with it, only had some ideas which would require it, so it's also hard for me
to dedicate time for it. However, I should get this running within the next
weeks.
Thanks for your contribution anyway!
Henrique
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Assignee: Roger Meier
> Labels: node, nodejs
> Fix For: 0.9
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64.patch
>
>
> I vote that the thrift library switches to the performance branch at
> https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the
> performance branch seems focused on this very issue. Also it includes the
> excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
