[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867406#comment-13867406
]
Pierre Lamot commented on THRIFT-2205:
--------------------------------------
Hi,
your welcome, thank you
One more point:
I still had some issues with the multiplex tests, and I think I finally found
it.
In MultiplexedProcessor, we are settings the method readMessageBegin of the
input object (inp) before giving it to the service, but by doing it we are
modifying the actual inp object, so next call to processor (esp. with buffered
messages) will reuse our stubbed readMessageBegin instead of the real one
What we should do is, instead of modifying the inp object is to create a proxy
object (containing the same methods members by reference) but with our stubbed
read method
> Node.js Test Server to support test.js JavaScript Browser test and sundry
> fixes
> -------------------------------------------------------------------------------
>
> Key: THRIFT-2205
> URL: https://issues.apache.org/jira/browse/THRIFT-2205
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Library, Node.js - Library
> Affects Versions: 1.0
> Environment: All
> Reporter: Randy Abernethy
> Assignee: Randy Abernethy
> Priority: Minor
> Labels: node, nodejs
> Attachments: 0001-node-test-update-with-JSON-Buf-fixes.patch,
> 0002-node-client-server-test-update.patch,
> 0003-node-throwed-error-should-be-instanciated.patch,
> 0004-node-fix-TJSONProtocol-parser.patch,
> 0005-node-tests-for-json-frame-and-bin-buf.patch
>
>
> Adds lib/nodejs/test/testsvr.js
> This server depends on ThriftTest[.js] and runs clean with test.js in the
> browser.
> Also in this patch:
> Repairs some shortfall in the Node JSON Protocol and transport. Fixes
> overflow on Javascript I64 tests. Improves static_server header output.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
