[
https://issues.apache.org/jira/browse/THRIFT-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263467#comment-14263467
]
ASF GitHub Bot commented on THRIFT-2926:
----------------------------------------
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/345#issuecomment-68587476
jslint is used via lib/js/test/build.xml which also runs the unit tests
test.js/test.html
My favorite would be integration of your tests into test.js/test.html and
use guessProtocolFactory within the server part
https://github.com/apache/thrift/blob/master/lib/js/test/src/test/Httpd.java#L217
> JavaScript: binary protocol implementation
> ------------------------------------------
>
> Key: THRIFT-2926
> URL: https://issues.apache.org/jira/browse/THRIFT-2926
> Project: Thrift
> Issue Type: New Feature
> Components: JavaScript - Library
> Affects Versions: 0.9.2
> Reporter: Radoslaw Gruchalski
> Labels: features, javascript
>
> I have implemented BinaryProtocol for the JS library. Implementation provided
> with unit tests. Looking for feedback.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
