[
https://issues.apache.org/jira/browse/THRIFT-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264923#comment-14264923
]
ASF GitHub Bot commented on THRIFT-2926:
----------------------------------------
Github user radekg commented on the pull request:
https://github.com/apache/thrift/pull/345#issuecomment-68758030
I've done a little bit more research into this. There's a major issue which
will surface in the unit test once I can get it integrated. I've got the test
properly integrated in the grunt task. What happens it that PhantomJS doesn't
like the following expression:
String.fromCharCode.apply(null, new Uint8Array( buffer ) )
This has been described here: https://github.com/mozilla/pdf.js/issues/1955
The problem is, if I apply the "fix" mentioned in the comments, the test
doesn't pass because unicode characters are decoded incorrectly. So, one way or
another, the test will fail. I can see only one solution to this issue. I am
going to close this pull request and provide the ThrifBinaryProtocol for JS as
an external module to be added on top of Thrift library. Once this is done, I
will post a link to the project here.
> JavaScript: binary protocol implementation
> ------------------------------------------
>
> Key: THRIFT-2926
> URL: https://issues.apache.org/jira/browse/THRIFT-2926
> Project: Thrift
> Issue Type: New Feature
> Components: JavaScript - Library
> Affects Versions: 0.9.2
> Reporter: Radoslaw Gruchalski
> Labels: features, javascript
>
> I have implemented BinaryProtocol for the JS library. Implementation provided
> with unit tests. Looking for feedback.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
