[
https://issues.apache.org/jira/browse/THRIFT-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264481#comment-14264481
]
ASF GitHub Bot commented on THRIFT-2926:
----------------------------------------
Github user radekg commented on the pull request:
https://github.com/apache/thrift/pull/345#issuecomment-68693024
@bufferoverflow I am trying to understand where the problem is. It seems
that travis is using a different method of testing than the one documented in
the README for js tests. The README assumes grunt as a main way of testing
while travis seems to be using ant?
I am also trying to figure out how does one run the main set of tests. Do I
have to follow this write up https://thrift.apache.org/docs/BuildingFromSource ?
Regarding the failing tests, travis complains about some invalid bitwise
operations while bitwise is allowed by build.xml jslint. Not sure where to
start looking for stuff.
> JavaScript: binary protocol implementation
> ------------------------------------------
>
> Key: THRIFT-2926
> URL: https://issues.apache.org/jira/browse/THRIFT-2926
> Project: Thrift
> Issue Type: New Feature
> Components: JavaScript - Library
> Affects Versions: 0.9.2
> Reporter: Radoslaw Gruchalski
> Labels: features, javascript
>
> I have implemented BinaryProtocol for the JS library. Implementation provided
> with unit tests. Looking for feedback.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
