[
https://issues.apache.org/jira/browse/THRIFT-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334387#comment-14334387
]
Randy Abernethy commented on THRIFT-3008:
-----------------------------------------
Hey Nobuaki,
Many thanks for the patch. I get failure only on the nodejs->cpp json cross
tests now (thrift/test/test.sh), big improvement.
All of the promise tests in thrift/lib/nodejs/test/testAll.sh fail with this
patch though so we need to bring the promise side up to date. If you can get
the thrift/lib/nodejs/test/testAll.sh test to run clean again, that would be
fantastic. If not I will commit the patch as is and create a new ticket for the
promise cleanup.
Best,
Randy
Relevant thrift/lib/nodejs/test/testAll.sh output:
===================================
ok 27 testInsanity
not ok 28 testException: TException
---
operator: fail
at: _rejected (/home/randy/thrift/node_modules/q/q.js:797:24)
...
ok 29 should be equal
Relevant thrift/test/test.sh output:
===========================
nodejs-nodejs binary buffered-ip success(0)
nodejs-nodejs binary buffered-ip-ssl success(0)
nodejs-nodejs binary framed-ip success(0)
nodejs-nodejs binary framed-ip-ssl success(0)
nodejs-nodejs compact buffered-ip success(0)
nodejs-nodejs compact buffered-ip-ssl success(0)
nodejs-nodejs compact framed-ip success(0)
nodejs-nodejs compact framed-ip-ssl success(0)
nodejs-nodejs json buffered-ip success(0)
nodejs-nodejs json buffered-ip-ssl success(0)
nodejs-nodejs json framed-ip success(0)
nodejs-nodejs json framed-ip-ssl success(0)
nodejs-cpp binary buffered-ip success(0)
nodejs-cpp binary buffered-ip-ssl success(0)
nodejs-cpp binary framed-ip success(0)
nodejs-cpp binary framed-ip-ssl success(0)
nodejs-cpp compact buffered-ip success(0)
nodejs-cpp compact buffered-ip-ssl success(0)
nodejs-cpp compact framed-ip success(0)
nodejs-cpp compact framed-ip-ssl success(0)
nodejs-cpp json buffered-ip failure(1)
nodejs-cpp json buffered-ip-ssl failure(1)
nodejs-cpp json framed-ip failure(1)
nodejs-cpp json framed-ip-ssl failure(1)
cpp-nodejs binary buffered-ip success(0)
cpp-nodejs binary buffered-ip-ssl success(0)
cpp-nodejs binary framed-ip success(0)
cpp-nodejs binary framed-ip-ssl success(0)
cpp-nodejs compact buffered-ip success(0)
cpp-nodejs compact buffered-ip-ssl success(0)
cpp-nodejs compact framed-ip success(0)
cpp-nodejs compact framed-ip-ssl success(0)
cpp-nodejs json buffered-ip success(0)
cpp-nodejs json buffered-ip-ssl success(0)
cpp-nodejs json framed-ip success(0)
cpp-nodejs json framed-ip-ssl success(0)
> Node.js server does not fully support exception
> -----------------------------------------------
>
> Key: THRIFT-3008
> URL: https://issues.apache.org/jira/browse/THRIFT-3008
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Compiler
> Reporter: Nobuaki Sukegawa
> Assignee: Randy Abernethy
>
> To my understanding (based on comment in TestThrift.thrift and C++ server
> behavior), servers should be able to send T(Application)Exception when an
> error occurred in the handler.
> Node.js server supports exceptions explicitly declared with "throws", but
> does not support the type of exceptions stated above.
> Also, the client test (lib/nodejs/test/test_driver.js) assumes current
> Node.js server behavior, resulting in cross test failures against C++ and
> Java reference implementations.
> This patch makes compiler generate server code that can emit errors in an
> identical way to C++ server code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
