[ 
https://issues.apache.org/jira/browse/THRIFT-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14339578#comment-14339578
 ] 

Hudson commented on THRIFT-3008:
--------------------------------

SUCCESS: Integrated in Thrift #1465 (See 
[https://builds.apache.org/job/Thrift/1465/])
THRIFT-3008: Node.js server does not fully support exceptions (ra: rev 
bd60b92c6f31c871d5bd52debbe75394575cd786)
* compiler/cpp/src/generate/t_js_generator.cc
* lib/nodejs/test/test_handler.js
* lib/nodejs/test/test_driver.js
* lib/nodejs/test/test-cases.js


> Node.js server does not fully support exception
> -----------------------------------------------
>
>                 Key: THRIFT-3008
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3008
>             Project: Thrift
>          Issue Type: Bug
>          Components: Node.js - Compiler
>            Reporter: Nobuaki Sukegawa
>            Assignee: Randy Abernethy
>             Fix For: 0.9.3
>
>
> To my understanding (based on comment in TestThrift.thrift and C++ server 
> behavior), servers should be able to send T(Application)Exception when an 
> error occurred in the handler.
> Node.js server supports exceptions explicitly declared with "throws", but 
> does not support the type of exceptions stated above.
> Also, the client test (lib/nodejs/test/test_driver.js) assumes current 
> Node.js server behavior, resulting in cross test failures against C++ and 
> Java reference implementations.
> This patch makes compiler generate server code that can emit errors in an 
> identical way to C++ server code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to