[
https://issues.apache.org/jira/browse/THRIFT-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338906#comment-14338906
]
Nobuaki Sukegawa commented on THRIFT-3008:
------------------------------------------
Hi Randy, thanks for the review.
As you pointed out, promise part of {{test_handler.js}} needed to be updated.
I also noticed that JSON test failures are caused by invalid test code for
testMapMap where the argument should be int rather than map of map.
I updated the pull request with above fixes.
> Node.js server does not fully support exception
> -----------------------------------------------
>
> Key: THRIFT-3008
> URL: https://issues.apache.org/jira/browse/THRIFT-3008
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Compiler
> Reporter: Nobuaki Sukegawa
> Assignee: Randy Abernethy
>
> To my understanding (based on comment in TestThrift.thrift and C++ server
> behavior), servers should be able to send T(Application)Exception when an
> error occurred in the handler.
> Node.js server supports exceptions explicitly declared with "throws", but
> does not support the type of exceptions stated above.
> Also, the client test (lib/nodejs/test/test_driver.js) assumes current
> Node.js server behavior, resulting in cross test failures against C++ and
> Java reference implementations.
> This patch makes compiler generate server code that can emit errors in an
> identical way to C++ server code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
