Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/690#discussion_r45070910
--- Diff: lib/cpp/src/thrift/transport/TSSLServerSocket.cpp ---
@@ -48,7 +48,12 @@ TSSLServerSocket::TSSLServerSocket(int port,
}
boost::shared_ptr<TSocket> TSSLServerSocket::createSocket(THRIFT_SOCKET
client) {
- return factory_->createSocket(client);
+ boost::shared_ptr<THRIFT_SOCKET> interruptSocketReader =
getInterruptSocket();
--- End diff --
The way I implemented this in TSocket was to provide two constructors - the
second one takes the interrupt socket as the second argument. If the same
logic is applied here, there would be no need to expose it via the method added
to TServerSocket called getInterruptSocket.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
