Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/690#discussion_r45071550
--- Diff: lib/cpp/src/thrift/transport/TServerSocket.cpp ---
@@ -659,6 +659,10 @@ shared_ptr<TSocket>
TServerSocket::createSocket(THRIFT_SOCKET clientSocket) {
}
}
+boost::shared_ptr<THRIFT_SOCKET> TServerSocket::getInterruptSocket() {
--- End diff --
Perhaps the interrupt socket and flag should be protected so they are
accessible to subclasses of TSocket instead of this? It's more of a style
comment however, I wouldn't gate check-in on changing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
