Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/690#issuecomment-157401129
I think the only concern I would have relative to this is that I don't see
a test that exercises the new code. There are tests that exercise all of the
interrupt code paths in TSocketInterruptTest, would like to see the same thing
for TSSLSocket, especially with the different wait behavior and BIO nonblocking
changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
