Github user CompileMaster commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1096#discussion_r80715525
--- Diff: lib/cpp/src/thrift/transport/TServerSocket.cpp ---
@@ -16,7 +16,9 @@
* specific language governing permissions and limitations
* under the License.
*/
-
+#if defined(_MSC_VER) && (_MSC_VER < 1900)
+#define snprintf _snprintf
--- End diff --
Thank you first, vs2013 has no snprintf function,but vs2015 has snprintf
function, i see the code of THRIFT_SNPRINTF in PlatformSocket.h, use the
THRIFT_SNPRINTF replace snprintf in TServerSocket.cpp will occurr link errors
when compiling under vs2015. use my patch code will compile sucessfully under
vs2013 and vs2015 at the same time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
