Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1096#discussion_r80728363
--- Diff: lib/cpp/src/thrift/transport/TServerSocket.cpp ---
@@ -16,7 +16,9 @@
* specific language governing permissions and limitations
* under the License.
*/
-
+#if defined(_MSC_VER) && (_MSC_VER < 1900)
+#define snprintf _snprintf
--- End diff --
Then I would suggest updating the code that makes THRIFT_SNPRINTF in
PlatformSocket.h to be correct for VS2013 and VS2015, and then changing the
code that uses snprintf directly to use THRIFT_SNPRINTF. We should keep this
type of platform abstraction in one place, in PlatformSocket.h.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
